RocketChat / RocketChat/Rocket.Chat

Timeout while changing avatar without internet connection

Open
#10,118 3 comments 3 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

area: ui/ux type: bug
Dominant language
TypeScript
Stars
46.1k
Forks
13.9k
Avg merge
3d 3h
Merged PRs (30d)
130

Description

Description:

When editing the profile, users have to wait for the "Loading suggestions..." timeout to change their avatar, even if the option "Accounts_SetDefaultAvatar" is disabled.
capture d ecran - 13032018 - 09 25 31

Server Setup Information:
  • Version of Rocket.Chat Server: 0.62.1
  • Operating System: Debian
  • Deployment Method(snap/docker/tar/etc): Tar
  • Number of Running Instances: 3
  • DB Replicaset Oplog: Enabled
  • Node Version: 8.9.3
  • mongoDB Version: 3.2.12
Steps to Reproduce:
  1. Disable the Internet connection or block gravatar.com on the rocketChat server
    $ sudo iptables -A OUTPUT -d 192.0.73.2 -j DROP
  2. Edit user profil in RocketChat
Expected behavior:

Do not try to contact gravatar.com when "Accounts_SetDefaultAvatar" is disabled or anything else that allow changing avatar without to wait for the timeout.

Actual behavior:

Users have to wait the timeout to gravatar.com to change their avatar

Relevant logs:

Mar 13 10:04:27 srv-01 nodejs-rocketchat0[26280]: rocketchat_logger rocketchat_logger.js:278 #033[34mMeteor ➔ method#033[39m getAvatarSuggestion -> userId: c8P5ygFNHtd2a4qDz , arguments: {}

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

The issue names the getAvatarSuggestion method and the Accounts_SetDefaultAvatar setting; start by tracing those references through the profile avatar flow. Reproduce with gravatar.com blocked or without an internet connection. Done means the disabled setting no longer triggers a Gravatar request or timeout, while users can still change their avatar.

Written by the indexing model from the issue text.

Assessment

Tech stack
javascript, typescript
Domain
backend, frontend
Issue type
Bug
Difficulty
3/5
Estimated time
1-2 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
42/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.