RocketChat / RocketChat/Rocket.Chat.ReactNative

bug: a lack of mutual TLS (mTLS) support for several API endpoints

Open
#7,371 2 comments 2 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

🐛 bug type: bug
Dominant language
TypeScript
Stars
2.4k
Forks
1.5k
Avg merge
1d 18h
Merged PRs (30d)
90

Description

Describe the Bug

The Problem

Both iOS and Android verions of RC do not send client certificate for the following endpoints while contacting a RC server with nginx as a reverse proxy instance in front of it

nginx is configured to authenticate users with certificates (mutual TLS)

The endpoints are:

  1. /admin/info
  2. /api/v1/push.get
Steps to Reproduce

Admin Panel

While clicking on the Admin panel button in RC app, the 400 Bad Request error occurs

nginx log entry:

GET /admin/info?layout=embedded HTTP/2.0" 400

This results in no possibility to access the administration workspace on mobile devices

Image

Push Notifications

While receiving a push notification message and trying to load more data from the server, the 400 Bad Request error occurs

As a result no additional information is received from the server

nginx log entry:

GET /api/v1/push.get?id={ID} HTTP/2.0" 400
Push Notifications: iOS

For the latter case it looks as if there is a lack of delegate: RocketChatURLSessionDelegate() in URLSession
https://github.com/RocketChat/Rocket.Chat.ReactNative/blob/e43a18147c3ecc7527a67e86dd58b4ca6fb4ce26/ios/NotificationService/NotificationService.swift#L268

but in the API class it is handled correctly
https://github.com/RocketChat/Rocket.Chat.ReactNative/blob/e43a18147c3ecc7527a67e86dd58b4ca6fb4ce26/ios/Shared/RocketChat/API/API.swift#L25

Push Notifications: Android

Pushes on the Android app: it looks like the new OkHttpClient.Builder() is missing a user credentials context while sending a request to /api/v1/push.get
https://github.com/RocketChat/Rocket.Chat.ReactNative/blob/e43a18147c3ecc7527a67e86dd58b4ca6fb4ce26/android/app/src/main/java/chat/rocket/reactnative/notification/LoadNotification.java#L111

Additional Information

Below are the previous related issue and PR, that could help to get the context of the problem:

  • #5204
  • #6130
Expected Behavior

No response

Actual Behavior

No response

Rocket.Chat Server Version

8.4.2

Rocket.Chat App Version

4.72.0

Device Name

iPhone, Samsung

OS Version

iOS 18, Android 16

Additional Context

p.s.
It's not directly related to this issue, but also there are two places doing the same thing in different manner

https://github.com/RocketChat/Rocket.Chat.ReactNative/blob/e43a18147c3ecc7527a67e86dd58b4ca6fb4ce26/ios/RocketChat%20Watch%20App/Client/RocketChatClient.swift#L25
https://github.com/RocketChat/Rocket.Chat.ReactNative/blob/cd6f2a89f5e9652ce83b8ae47669c3a638e7ff15/ios/RocketChat%20Watch%20App/Client/URLSessionCertificateHandling.swift#L5

https://github.com/RocketChat/Rocket.Chat.ReactNative/blob/cd6f2a89f5e9652ce83b8ae47669c3a638e7ff15/ios/Shared/RocketChat/API/API.swift#L14

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start by comparing the certificate handling in ios/NotificationService/NotificationService.swift with ios/Shared/RocketChat/API/API.swift, then inspect android/app/src/main/java/chat/rocket/reactnative/notification/LoadNotification.java. Verify the affected /admin/info and /api/v1/push.get requests use the required client-certificate context on both platforms and succeed through an nginx mutual-TLS proxy.

Written by the indexing model from the issue text.

Assessment

Tech stack
java, react-native, swift
Domain
api, authentication, mobile, security
Issue type
Bug
Difficulty
4/5
Estimated time
3-5 days
Activity status
Active
Clarity
Mostly clear
Newbie friendliness
55/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.