RocketChat / RocketChat/Rocket.Chat.ReactNative
chore: Unify usage of openAppSettings
Nobody has claimed this yet.
- Dominant language
- TypeScript
- Stars
- 2.4k
- Forks
- 1.5k
- Avg merge
- 1d 18h
- Merged PRs (30d)
- 90
Description
Search for app-settings: and you'll find this
We have openAppSettings though, so we should use it in those places.
https://github.com/RocketChat/Rocket.Chat.ReactNative/blob/b1105102f9b2a13b40970b31a6fc011ca9bad158/app/lib/methods/helpers/openAppSettings.ts
Also notice it's a promise. We should handle it.
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Search the React Native app for app-settings: and inspect each caller alongside app/lib/methods/helpers/openAppSettings.ts. Replace the direct usage with the shared helper and account for its promise in each location. Done means the identified callers consistently use openAppSettings without unhandled promises.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- react-native, typescript
- Domain
- mobile
- Issue type
- Refactor
- Difficulty
- 3/5
- Estimated time
- 1-2 days
- Activity status
- Stale
- Clarity
- Clearly specified
- Newbie friendliness
- 55/100