RocketChat / RocketChat/Rocket.Chat.ReactNative
bug: answering on desktop client while phone client is active causes both sessions to join the video conference
Nobody has claimed this yet.
- Dominant language
- TypeScript
- Stars
- 2.4k
- Forks
- 1.5k
- Avg merge
- 1d 18h
- Merged PRs (30d)
- 90
Description
Description
Answering a call from your desktop client while your phone app is active will cause the video conference to start both in your desktop app and your phone.
Expected Behavior
You should only join from the client that you pick-up the call from. (in this case Desktop client)
Actual Behavior
Both the phone and desktop client joins the call causing feedback of the noise
Versions
Rocket.Chat server version: 7.3.1
Rocket.Chat desktop client: 4.1.2
Rocket.Chat mobile app Android: 4.57.2
Rocket.Chat mobile app Apple: 4.57.2.73496
I'm able to reproduce the issue on both Android and IOS.
Steps to Reproduce
- Open up your Rocket.Chat desktop app
- Open up your Rocket.Chat mobile app
- Have a friend call you through a direct message (in our case we use Video Call, Jitsi)
- Check that it's ringing on both phone and desktop client
- Pick up on desktop client
- You are now in a call with both your Phone, Desktop & Friend
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start by reproducing the call with the desktop and mobile clients active, following the video-call answer flow described in the issue. Trace how answering on one client affects the other; done means only the client that accepts the call joins the conference, without feedback from the second session.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- react-native, typescript
- Domain
- audio-video-rtc, mobile
- Issue type
- Bug
- Difficulty
- 4/5
- Estimated time
- 3-5 days
- Activity status
- Quiet
- Clarity
- Mostly clear
- Newbie friendliness
- 45/100