RocketChat / RocketChat/Rocket.Chat.ReactNative

Apply skeleton for message images and on workspace avatar

Open
#4,810 14 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

🍭 good first issue 👍 improvement
Dominant language
TypeScript
Stars
2.4k
Forks
1.5k
Avg merge
1d 18h
Merged PRs (30d)
90

Description

Overview

We’ve been rendering a loading indicator for images, but we introduced the skeleton usage for videoconf elements and on the web.

It’s a better experience if we unify this behavior.

To be done
  • Apply skeleton on WorkspaceView’s ServerAvatar
  • Apply skeleton on Message’s MessageImage
  • Apply skeleton on Markdown’s MessageImage
  • Remove react-native-image-progress and react-native-progress

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start by locating WorkspaceView’s ServerAvatar, Message’s MessageImage, and Markdown’s MessageImage, then compare their current loading indicators with the existing skeleton usage for videoconf elements and on the web. Update all three image displays to use the unified skeleton behavior and verify that react-native-image-progress and react-native-progress can be removed.

Written by the indexing model from the issue text.

Assessment

Tech stack
react-native, typescript
Domain
mobile
Issue type
Refactor
Difficulty
3/5
Estimated time
1-2 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
35/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.