RocketChat / RocketChat/Rocket.Chat.ReactNative
Separators don't render correctly if font size a11y is decreased
Open
Nobody has claimed this yet.
🍭 good first issue
🐛 bug
- Dominant language
- TypeScript
- Stars
- 2.4k
- Forks
- 1.5k
- Avg merge
- 1d 18h
- Merged PRs (30d)
- 90
Description
Overview
It happens mostly on Android.
Check how some separators aren’t getting rendered below.
That happens because StyleSheet.hairlineWidth calculates its value based on PixelRatio.
To be done
- Stop using StyleSheet.hairlineWidth and apply 1 instead
- Evaluate all places impacted by this and apply the new value
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Search the project for uses of StyleSheet.hairlineWidth, then inspect the affected separator components and reproduce the issue on Android with a reduced accessibility font size. Replace the impacted value as specified and verify that all separators render correctly across the affected locations.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- react-native, typescript
- Domain
- mobile
- Issue type
- Bug
- Difficulty
- 4/5
- Estimated time
- 3-5 days
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 35/100