RocketChat / RocketChat/Rocket.Chat.ReactNative
Subscription synchronization on app start does not correctly sync removed items
Open
Nobody has claimed this yet.
ℹ️ needs info
- Dominant language
- TypeScript
- Stars
- 2.4k
- Forks
- 1.5k
- Avg merge
- 1d 18h
- Merged PRs (30d)
- 90
Description
Description:
Environment Information:
- Rocket.Chat Server Version: 4.3.1
- Rocket.Chat App Version: 4.24.0
- Device Name: Pixel 3
- OS Version: Android 12
Steps to reproduce:
- Open mobile application and login to initialize database
- Close the app completely
- Login via web to same account and leave (not delete) a room to remove the subscription for that user.
- Re-open mobile application and the room that was left still exists
Expected behavior:
The room that was left should be removed from the RoomsListView
Actual behavior:
The room persists even after leaving
Additional context:
Related to #3411 I believe, this fixes the same behavior. I found the issue in the sync logic and will be attaching a small pull request shortly.
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Trace the subscription synchronization logic that runs when the mobile app starts and compare it with the RoomsListView state after a room is left on the web. Reproduce the listed login and restart sequence; done means the remotely removed room no longer appears in RoomsListView.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- react-native, typescript
- Domain
- mobile
- Issue type
- Bug
- Difficulty
- 3/5
- Estimated time
- 1-2 days
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 35/100