RocketChat / RocketChat/Rocket.Chat.ReactNative

App not working properly if default max record amount for REST API is decreased

Open
#3,316 3 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

🐛 bug
Dominant language
TypeScript
Stars
2.4k
Forks
1.5k
Avg merge
1d 18h
Merged PRs (30d)
90

Description

Description:

https://github.com/RocketChat/Rocket.Chat/issues/22843#issuecomment-892962689

Administration > General > Api
Dropping Max Record Amount below 50 and Default Count below 15 does not allow the mobile app to gather all the settings it needs to show the login form.

Environment Information:
  • Rocket.Chat Server Version: 3.17.0
  • Rocket.Chat App Version: 4.18
  • Device Name: Unkown Dev
  • OS Version: 14.5.1
Steps to reproduce:
  1. Go to Administration > General > API
  2. Drop max record amount below 50 and default count to 10
  3. Open RocketChat Mobile
  4. Enter as a new workspace URL
  5. You will get either a black screen with no login prompt

The reason for this is the call to the public.settings does not pass a count parameter so dropping the default count lower than 15 causes issues with rendering the form.

Expected behavior:

To be able to download all settings to show login prompt but since no count parameter is passed with URL it uses the default which is lower than what it needs.

Actual behavior:

Black screen that the user cannot log in or proceed to gain access to the application.

Additional context:

Passing a count parameter above 15 has no effect.
Raising the default count to 15 solves the issue but we may want to limit the APIs so a count parameter might be preferable?.

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Reproduce the failure by lowering Max Record Amount and Default Count in Administration > General > API, then opening the mobile app with a new workspace URL. Trace the request to public.settings and verify that the login form renders when those server defaults are below the current thresholds.

Written by the indexing model from the issue text.

Assessment

Tech stack
react-native, typescript
Domain
api, mobile
Issue type
Bug
Difficulty
3/5
Estimated time
1-2 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
35/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.