RocketChat / RocketChat/Rocket.Chat.ReactNative

Upload not working when phone language set to Turkish

Open
#3,040 3 comments 3 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

🐛 bug
Dominant language
TypeScript
Stars
2.4k
Forks
1.5k
Avg merge
1d 18h
Merged PRs (30d)
90

Description

Description:

We are using Rocket.Chat in Turkey and realized there is a problem when uploading files on Android, after investigating the source of problem we discover that this problem happens when phone language is set to Turkish and not related to app language.

I am working on a fork of react-native project, and tried rocket.chat official app from store, problem exists on both of them.

Environment Information:
  • Rocket.Chat Server Version: 3.12.1
  • Rocket.Chat App Version: 4.15.0
  • Device Name: Samsung (Galaxy J7, Galaxy A6, Galaxy A8+, Galaxy A7), Xiaomi Mi A2 Lite, Android Emulator API 30
  • OS Version: Android 11, Android 10, Android 9
Steps to reproduce:
  1. Settings -> System -> Language & input -> Languages -> change language to Turkish (or alternative path of changing phone language)
  2. After that open Rocket.Chat and try to upload a file
Expected behavior:

Upload file works on phone with no problem regardless of phone localization

Actual behavior:

Error uploading message would show with the file name.

Additional context:

If phone language changed to English again upload files works fine, I tried to set app language to Turkish while phone language is English upload works also.

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

No source file or test is named in the issue. First reproduce the upload failure on Android with the device language set to Turkish, then trace the mobile upload path; done means file uploads succeed with Turkish device localization as well as English.

Written by the indexing model from the issue text.

Assessment

Tech stack
android, react-native, typescript
Domain
internationalization, mobile
Issue type
Bug
Difficulty
3/5
Estimated time
1-2 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
35/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.