RocketChat / RocketChat/Rocket.Chat.ReactNative
Add react-native-pdf
Nobody has claimed this yet.
- Dominant language
- TypeScript
- Stars
- 2.4k
- Forks
- 1.5k
- Avg merge
- 1d 18h
- Merged PRs (30d)
- 90
Description
Description:
The current behavior of downloading pdf files is a webview implementation, which can be improved if we use an app-inbuilt pdf viewer that also allows us to leverage local document cache ( something similar to this PR https://github.com/RocketChat/Rocket.Chat.ReactNative/pull/2809) and also pdf-thumbnails which can be a good UX.
Steps to reproduce:
- Open a pdf file from messages.
Expected behavior:
Should open a pdf viewer baked into the app
Actual behavior:
on iOS: opens the pdf in a webview, on android: file starts downloading.
Additional context:
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start by tracing the current PDF message-opening and download flow, then compare it with the approach in pull request 2809. Done means PDFs open in an in-app viewer on both iOS and Android, with local document caching and consideration of PDF thumbnails as described.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- react-native, typescript
- Domain
- mobile
- Issue type
- Feature
- Difficulty
- 4/5
- Estimated time
- 3-5 days
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 35/100