RocketChat / RocketChat/Rocket.Chat.Electron

Clearing storage on exit to close OAuth sessions for public / shared computers

Open
#646 0 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Dominant language
TypeScript
Stars
1.7k
Forks
835
Avg merge
1d 21h
Merged PRs (30d)
15

Description

My Setup

  • Operating System:
    MacOs Sierra 10.12.6
    Windows 10

  • App Version:
    2.9 (on Mac)
    2.10.1 (on Windows)

  • I have tested with the latest version (Windows)
  • I can simulate the issue easily

Description

This is a problem regarding the usage of the RocketChat desktop app on a public / shared computer.
If you use to login via OAuth the session it is still running even when you exit the desktop app.
So when you start the desktop app afterwards, you'll be automatically logged in again.
You can stop this by clearing the storage via the DevTools.
It would be nice to have the option to logout from all servers on exit.
It could be an additional setting, so that private users don't need to login again each time they open RocketChat.

Current Behavior

You exit the RocketChat desktop app and if you open it again you're still logged in.

Expected Behavior

You exit the RocketChat desktop app and if you open it again you'll need to login again.

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start by locating the Electron app's exit lifecycle, OAuth session handling, and persistent storage cleared through DevTools. Then find where application settings are defined to assess how an optional logout-on-exit setting would fit. Done means the app can clear stored sessions on exit when enabled, while preserving the current behavior for private users.

Written by the indexing model from the issue text.

Assessment

Tech stack
electron, typescript
Domain
authentication, desktop
Issue type
Feature
Difficulty
4/5
Estimated time
3-5 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
35/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.