Unable to deploy app with custom nameslug

Open
#66 2 comments 1 reaction 0 assignees View on GitHub

Nobody has claimed this yet.

Assessment

Difficulty
3/5
Estimated time
1-2 days
Newbie friendliness
35/100
Issue type
Bug
Clarity
Mostly clear
Activity status
Stale
Tech stack
node.js, typescript
Domain
cli

Research direction

Start with the deploy command in lib/commands/deploy.js, especially asyncSubmitData around line 100, and reproduce the failure using the shown app.json and a custom nameSlug. Compare deployment behavior for a new slug with an existing marketplace slug. Done means a newly generated app with a custom nameSlug deploys successfully or reports the underlying deployment error clearly.

Written by the indexing model from the issue text.

Description

After creating a new app with the rc-apps create command. I get the following app.json.

{
    "id": "f044466e-8540-4168-aa91-4cc94a3c860c",
    "version": "0.0.1",
    "requiredApiVersion": "^1.4.0",
    "iconFile": "icon.png",
    "author": {
        "name": "Mathieu Charest",
        "homepage": "http://localhost",
        "support": "http://localhost"
    },
    "name": "Draw.io",
    "nameSlug": "drawio",
    "classFile": "DrawIoApp.ts",
    "description": "Draw.io"
}

Then, I simply try to deploy the default created app with the rc-apps deploy command and I get

packaging your app... packaged!
deploying your app... !
Error: Deployment error: undefined
    at Deploy.asyncSubmitData (C:/Users/Mathieu/AppData/Roaming/npm/node_modules/@rocket.chat/apps-cli/lib/commands/deploy.js:100:19)
    at async Deploy.run (C:/Users/Mathieu/AppData/Roaming/npm/node_modules/@rocket.chat/apps-cli/lib/commands/deploy.js:47:9)
    at async Deploy._run (C:/Users/Mathieu/AppData/Roaming/npm/node_modules/@rocket.chat/apps-cli/node_modules/@oclif/command/lib/command.js:44:20)
    at async Config.runCommand (C:/Users/Mathieu/AppData/Roaming/npm/node_modules/@rocket.chat/apps-cli/node_modules/@oclif/config/lib/config.js:160:9)
    at async Main.run (C:/Users/Mathieu/AppData/Roaming/npm/node_modules/@rocket.chat/apps-cli/node_modules/@oclif/command/lib/main.js:21:9)
    at async Main._run (C:/Users/Mathieu/AppData/Roaming/npm/node_modules/@rocket.chat/apps-cli/node_modules/@oclif/command/lib/command.js:44:20)

The only way for me to deploy the app is changing the nameslug to an app that exists in the market. Like Appear.In.

{
    "id": "f044466e-8540-4168-aa91-4cc94a3c860c",
    "version": "0.0.1",
    "requiredApiVersion": "^1.4.0",
    "iconFile": "icon.png",
    "author": {
        "name": "Mathieu Charest",
        "homepage": "http://localhost",
        "support": "http://localhost"
    },
    "name": "Draw.io",
    "nameSlug": "appearin",
    "classFile": "DrawIoApp.ts",
    "description": "Draw.io"
}

packaging your app... packaged!
deploying your app... deployed!
Dominant language
TypeScript
Stars
49
Forks
39
No merged PRs in 30d

Contributor guide

No contributing guide indexed for this repository

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

More from RocketChat/Rocket.Chat.Apps-cli

All issues in RocketChat/Rocket.Chat.Apps-cli

Similar issues

More TypeScript issues

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.