ignoredFiles are not ignored

Open
#131 2 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Assessment

Difficulty
1/5
Estimated time
Under an hour
Newbie friendliness
45/100
Issue type
Bug
Clarity
Clearly specified
Activity status
Stale
Tech stack
typescript
Domain
cli

Research direction

Start in src/compiler/getAppSource.ts at the linked line and trace how ignoredFiles from .rcappsconfig is passed into the file-selection logic. Confirm the behavior with a .vscode/** entry and verify that TypeScript files under .vscode are excluded.

Written by the indexing model from the issue text.

Description

When I add .vscode/** in the ignoredFiles of .rcappsconfig, Typescript files in this directory are not ignored. (I use the Local History addons in VSCode, which adds local versions of files in the .vscode directory).

I tracked down the error to this line:
https://github.com/RocketChat/Rocket.Chat.Apps-compiler/blob/f574fffd9a7c40fca2d963979f02a3023a5e2a1e/src/compiler/getAppSource.ts#L14

This line should use ignoredFiles instead.

Dominant language
TypeScript
Stars
49
Forks
39
No merged PRs in 30d

Contributor guide

No contributing guide indexed for this repository

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

More from RocketChat/Rocket.Chat.Apps-cli

All issues in RocketChat/Rocket.Chat.Apps-cli

Similar issues

More TypeScript issues

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.