RocketChat / RocketChat/EmbeddedChat
Implement thread message event listeners
Open
Nobody has claimed this yet.
bug
- Dominant language
- JavaScript
- Stars
- 165
- Forks
- 381
- Avg merge
- 1d 2h
- Merged PRs (30d)
- 1
Description
Description:
Currently, there is a TODO in packages/api/src/EmbeddedChatApi.ts (line 239) that requires implementing logic to call thread message event listeners
Steps to reproduce:
- Open a thread in a Rocket.Chat room
- Send a message in the thread
- Observe that thread message event listeners are not being called
Expected behavior:
- Thread messages should trigger event listeners
- Components listening to thread messages should receive updates in real-time
- Thread message events should be handled similarly to regular message events
Actual behavior:
- Thread message event listeners are not being invoked
- Components do not receive thread message updates
- The TODO comment indicates this functionality is not yet implemented
Implementation Notes:
- This should be implemented in the
_doConnect()method (like other subscriptions) - Should follow the existing pattern for message and notification subscriptions
- Needs to integrate with the callback system already in place
Contributor guide
No contributing guide indexed for this repository
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start in packages/api/src/EmbeddedChatApi.ts at the TODO on line 239 and inspect _doConnect(). Compare the existing message and notification subscriptions and trace the callback system. Done means thread messages invoke the registered listeners and deliver real-time updates consistently with regular message events.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- javascript
- Domain
- api
- Issue type
- Feature
- Difficulty
- 3/5
- Estimated time
- 1-2 days
- Activity status
- Active
- Clarity
- Clearly specified
- Newbie friendliness
- 76/100