RocketChat / RocketChat/EmbeddedChat

Issue: Add Cache Breaking Notice for Removed Query Parameter in API

Open
#1,025 4 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

bug
Dominant language
JavaScript
Stars
165
Forks
381
Avg merge
1d 2h
Merged PRs (30d)
1

Description

Location

File: apps/meteor/app/api/server/v1/im.ts
Line: 537


Problem

A TODO comment indicates that a cache-breaking notice should be added because a query parameter was removed from the API.
Currently, this missing notice can cause confusion for developers upgrading or using cached API responses.

Existing Code:
// TODO: CACHE: Add Breaking notice since we removed the query param

// Proposed Solution
// Add appropriate deprecation notice
// NOTICE: This endpoint parameter was removed due to security concerns and 
// performance optimization.
// The feature was replaced with a more secure implementation in subsequent versions.
// Please refer to the API documentation for migration details.

Contributor guide

No contributing guide indexed for this repository

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start at line 537 of apps/meteor/app/api/server/v1/im.ts and read the surrounding endpoint and cache-handling code. Add the cache-breaking or deprecation notice for the removed query parameter, with wording that matches the API migration guidance; the issue is complete when the notice is present and clearly explains the change.

Written by the indexing model from the issue text.

Assessment

Tech stack
typescript
Domain
api, backend
Issue type
Feature
Difficulty
1/5
Estimated time
Under an hour
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
45/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.