RoboStack / RoboStack/vinca

Builds from source repositories: control submodule pull

Open
#127 2 comments 1 reaction 0 assignees View on GitHub

Nobody has claimed this yet.

Dominant language
Python
Stars
20
Forks
24
Avg merge
1d 16h
Merged PRs (30d)
17

Description

Lately I've been building most packages directly from their source repositories. Not best-practice perhaps, but in this case a necessity.

Adding an entry to rosdistro_additional_recipes.yaml is easy enough and works well.

Some of those repositories however use submodules, and similar to the motivation given in prefix-dev/rattler-build#2107 it would be nice if we could prevent those submodules from getting pulled: they may not be necessary for the build of a particular package from a set of packages in a (mono)repository or undesired for other reasons.

prefix-dev/rattler-build#2158 seems to have added a way to make rattler-build ignore them, but I couldn't find a way for Vinca to generate recipes that added the submodules: false key-value pair to the source dict.

Would there be interest in adding this? If so, what would be the nicest way of doing that?

Contributor guide

No contributing guide indexed for this repository

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start by tracing how rosdistro_additional_recipes.yaml entries are turned into generated recipe source dictionaries, then compare the requested behavior with rattler-build#2158. Done means Vinca can express the option and generated recipes include submodules: false when requested, without changing existing recipes by default.

Written by the indexing model from the issue text.

Assessment

Tech stack
python
Domain
build-system
Issue type
Feature
Difficulty
3/5
Estimated time
1-2 days
Activity status
Quiet
Clarity
Mostly clear
Newbie friendliness
62/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.