Roblox / Roblox/rodux

Don't fire update if the top-level state doesn't change after a reducer

Open
#32 3 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

enhancement
Dominant language
Lua
Stars
334
Forks
78
PR merge metrics
No merged PRs in 30d

Description

This probably doesn't come up often in practice, but it seems like a fairly low-effort optimization for this case.

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

The issue concerns reducer-driven state updates in the Rodux source. Start by tracing how reducer results lead to update notifications, then determine where the top-level state comparison belongs. Done means unchanged top-level state no longer fires an update while changed state continues to do so, with regression coverage for both cases.

Written by the indexing model from the issue text.

Assessment

Tech stack
lua
Domain
tooling
Issue type
Feature
Difficulty
3/5
Estimated time
1-2 days
Activity status
Active
Clarity
Needs clarification
Newbie friendliness
48/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.