Deprecate 'changed' and introduce new store update signal
Nobody has claimed this yet.
- Dominant language
- Lua
- Stars
- 334
- Forks
- 78
- PR merge metrics
- No merged PRs in 30d
Description
When I built the first version of Rodux, the best way to respond to changes outside of something like React/Roact wasn't very well understood.
I think that we understand now that the best way to respond to changes in the Rodux store is to keep the last value you had, and on update, compare the new store state with it. In short, you should ignore the second argument of the changed event!
This issue covers two gripes:
- I want to remove the second value passed by the
changedsignal because it's a bad practice - I want to fix the naming of the changed signal to indicate that it's a signal (
onUpdatemaybe?)
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start by locating the Rodux store's changed signal and its public API. Review how listeners receive the signal, then define the compatibility and naming decisions needed for a replacement such as onUpdate. Done means the old second value is addressed and the new update signal behavior and migration path are documented and tested.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- lua
- Domain
- tooling
- Issue type
- Feature
- Difficulty
- 5/5
- Estimated time
- Over a week
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 25/100