RobertCraigie / RobertCraigie/pyright-python
Remove latest version warning
Nobody has claimed this yet.
- Dominant language
- Python
- Stars
- 277
- Forks
- 31
- Avg merge
- 4h 22m
- Merged PRs (30d)
- 3
Description
I suspect the latest version warning has caused more pain than usefulness, for a couple of reasons.
- It's caused issues with flags like
--outputjsonwhich have since been fixed but it's a bit of a whack-a-mole situation and I wouldn't be surprised if other issues crop up in the future. - It makes the CLI slower, ~200ms on my machine which isn't too bad but it would be much slower if the user is on a slow network
Obviously with features like this one it's very hard, if not impossible, to actually judge how many people this has positively impacted. As such, I'm proposing removing the latest version warning log and if there is an uptick in pyright issues reported by users on an old version, we can consider adding it back in.
Contributor guide
No contributing guide indexed for this repository
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start by locating the CLI code that emits the latest version warning and trace how its version check affects flags such as --outputjson. Verify the warning is no longer emitted and that the CLI still handles --outputjson correctly without the warning's network-related delay.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- python
- Domain
- cli
- Issue type
- Feature
- Difficulty
- 3/5
- Estimated time
- 1-2 days
- Activity status
- Quiet
- Clarity
- Mostly clear
- Newbie friendliness
- 52/100