RobLoach / RobLoach/raylib-libretro

shader cycling via hotkey doesn't update menu label

Open Beginner friendly
#288 0 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

bug
Dominant language
C
Stars
38
Forks
8
PR merge metrics
No merged PRs in 30d

Description

In bin/raylib-libretro.c:712, cycling shaders with a hotkey works visually but the menu label for the current shader preset is not updated. There is a TODO comment at that line noting this.

Suggested Implementation

After CycleLibretroShader() / CycleLibretroShaderReverse(), call whatever setter or refresh function the menu uses to sync its shader label widget with the current shader state.

QA

  • Cycle shader with hotkey
  • Open Settings > Graphics > Shader
  • Confirm label matches the active shader

Contributor guide

No contributing guide indexed for this repository

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start at bin/raylib-libretro.c:712 and inspect the TODO alongside CycleLibretroShader() and CycleLibretroShaderReverse(). Trace the setter or refresh function used by the shader menu label, then verify the label after cycling in both directions with the Settings > Graphics > Shader QA steps.

Written by the indexing model from the issue text.

Assessment

Tech stack
c
Domain
frontend
Issue type
Bug
Difficulty
2/5
Estimated time
1-3 hours
Activity status
Quiet
Clarity
Clearly specified
Newbie friendliness
68/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.