RoaringBitmap / RoaringBitmap/roaring
Validate bitmap cardinality in BenchmarkRealData* functions
Nobody has claimed this yet.
- Dominant language
- Go
- Stars
- 2.9k
- Forks
- 262
- Avg merge
- 2h 34m
- Merged PRs (30d)
- 8
Description
I think it makes sense to validate bitmap cardinality in BenchmarkRealData* functions. In some rare cases the aggregation_test.go test suite does not reveal subtle bugs that could be introduced while working on wide union functions. Typically such work is done to improve performance and benchmarks are run as part of it. So even though BenchmarkRealData* is not part of test suite I think I'd allow us to catch some bugs.
I'd also help me avoiding publishing benchmarks that are plain wrong as in #164. :)
Contributor guide
No contributing guide indexed for this repository
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start with the BenchmarkRealData* functions and review aggregation_test.go, then compare the benchmark behavior with the issue referenced as #164. Add cardinality validation so benchmark results expose incorrect bitmap unions, and confirm the relevant benchmarks detect mismatches without relying only on the aggregation test suite.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- go
- Domain
- performance, testing-qa
- Issue type
- Feature
- Difficulty
- 2/5
- Estimated time
- 1-3 hours
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 35/100