RoaringBitmap / RoaringBitmap/CRoaring

cpp headers not in target_include_directories

Open
#175 1 comment 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

enhancement help wanted
Dominant language
C
Stars
1.9k
Forks
334
Avg merge
2d 5h
Merged PRs (30d)
17

Description

The cpp headers are not added to the target_include_directories. Without that it is hard to use CRoaring from a local subdirectory from C++ without install. (it can not find the cpp headers)

One would probably need to add a new subdirectory "roaring" into the cpp directory to do that in a clean way.

Contributor guide

No contributing guide indexed for this repository

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start in the cpp directory and inspect how target_include_directories currently configures the C++ headers. Check the proposed roaring subdirectory layout and verify that a local, uninstalled CRoaring subdirectory can find the C++ headers; done means that include lookup works for C++ consumers.

Written by the indexing model from the issue text.

Assessment

Tech stack
cmake, cpp
Domain
build-system
Issue type
Bug
Difficulty
3/5
Estimated time
1-2 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
38/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.