RipMeApp / RipMeApp/ripme

CLI shows erroneous and incomplete information

Open
#232 0 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

bug
Dominant language
Java
Stars
4.1k
Forks
673
PR merge metrics
No merged PRs in 30d

Description

  • Ripme version: 1.6.13
  • Java version: 1.8.0_151
  • Operating system: Microsoft Windows [Version 10.0.15063]
  • Exact URL you were trying to rip when the problem occurred: http://reddit.com/u/bbypocahontas
  • Please include any additional information about how to reproduce the problem: Using the command line java -jar ripme.jar -u http://reddit.com/u/bbypocahontas re-rip with remember URL history.

Expected Behavior

Show messages like the UI does when URLs have been remembered.

Already downloaded https://i.imgur.com/jcXNyAR.jpg

Actual Behavior

Shows incomplete URLs and "Unable to rip URL" instead of showing that URLs have been remembered.

E:\dev\ripme>java -jar ripme.jar -u http://reddit.com/u/bbypocahontas
Loaded E:\dev\ripme\rip.properties
Loaded log4j.properties
Initialized ripme v1.6.13
[!] Unable to rip URL: http://hutt.co/bbypocah
[!] Unable to rip URL: https://www.reddit.com/r/bbyPocahontas/)**
[!] Unable to rip URL: https://www.reddit.com/user/bbypocahontas/)*
[!] Unable to rip URL: http://instagram.com/bbypocah
[!] Unable to rip URL: http://hutt.co/bbypocah
[!] Unable to rip URL: http://instagram.com/bbypocah
[!] Unable to rip URL: https://www.reddit.com/r/bbyPocahontas/
[!] Unable to rip URL: http://hutt.co/bbypocah
[!] Unable to rip URL: http://hutt.co/bbypocah
[!] Unable to rip URL: http://hutt.co/bbypocah
[!] Unable to rip URL: https://reddit.com/r/bbypocahontas
[!] Unable to rip URL: https://reddit.com/user/bbypocahontas
[!] Unable to rip URL: http://instagram.com/bbypocah
[!] Unable to rip URL: http://hutt.co/bbypocah
[!] Unable to rip URL: http://instagram.com/bbypocah
[!] Unable to rip URL: http://reddit.com/r/bbypocahontas
[!] Unable to rip URL: https://www.reddit.com/r/bbyPocahontas
[!] Unable to rip URL: https://www.reddit.com/r/bbyPocahontas/comments/7af1hr/strappy_underwear/?st=J9J13WN3&sh=be413376
[!] Unable to rip URL: http://instagram.com/bbypocah
[!] Unable to rip URL: https://www.reddit.com/r/bbyPocahontas/comments/75gln1/how_was_your_long_weekend/?st=J9E8FO52&sh=562af247
[!] Unable to rip URL: https://www.reddit.com/r/bbyPocahontas/
[!] Unable to rip URL: http://instagram.com/bbypocah
[!] Unable to rip URL: http://hutt.co/bbypocah
[!] Unable to rip URL: https://www.reddit.com/r/bbyPocahontas/
[!] Unable to rip URL: https://www.reddit.com/user/bbypocahontas
[!] Unable to rip URL: http://instagram.com/bbypocah
[!] Unable to rip URL: http://hutt.co/bbypocah
[!] Unable to rip URL: https://www.reddit.com/r/bbyPocahontas
[!] Unable to rip URL: https://www.reddit.com/r/bbyPocahontas/
[!] Unable to rip URL: https://www.reddit.com/user/bbypocahontas
Retrieving https://gfycat.com/UnkemptCelebratedDonkey
Retrieving https://gfycat.com/gifs/detail/UnkemptCelebratedDonkey
Exception while retrieving gfycat page:
java.io.IOException: Could not find source#mp4source at https://gfycat.com/gifs/detail/UnkemptCelebratedDonkey
        at com.rarchives.ripme.ripper.rippers.video.GfycatRipper.getVideoURL(GfycatRipper.java:70)
        at com.rarchives.ripme.utils.RipUtils.getFilesFromURL(RipUtils.java:64)
        at com.rarchives.ripme.ripper.rippers.RedditRipper.handleURL(RedditRipper.java:190)
        at com.rarchives.ripme.ripper.rippers.RedditRipper.parseJsonChild(RedditRipper.java:157)
        at com.rarchives.ripme.ripper.rippers.RedditRipper.getAndParseAndReturnNext(RedditRipper.java:89)
        at com.rarchives.ripme.ripper.rippers.RedditRipper.rip(RedditRipper.java:64)
        at com.rarchives.ripme.App.rip(App.java:67)
        at com.rarchives.ripme.App.ripURL(App.java:177)
        at com.rarchives.ripme.App.handleArguments(App.java:169)
        at com.rarchives.ripme.App.main(App.java:56)
[!] Unable to rip URL: https://youtu.be/InS3Jjtpks4
^C

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start with the CLI flow in com.rarchives.ripme.App, then inspect RedditRipper, RipUtils, and GfycatRipper using the reproduced command and stack trace. Compare CLI output with the UI's remembered-URL messages; done means remembered URLs are reported with complete URLs rather than as unable-to-rip errors.

Written by the indexing model from the issue text.

Assessment

Tech stack
java
Domain
cli
Issue type
Bug
Difficulty
4/5
Estimated time
3-5 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
35/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.