Riddy21 / Riddy21/Friday_Budgeting_Pro
[P5] Add 'savings' as valid item_type in line_items
Open
@Riddy21 is already working on this.
Since May 31, 2026.
task
- Dominant language
- Python
- Stars
- 1
- Forks
- 1
- PR merge metrics
- No merged PRs in 30d
Description
Summary
Add savings as a valid item_type in the line_items table. Currently only income and expense are accepted.
Requirements
- Update the
line_items.item_typecolumn indb/schema.sqlto documentsavingsas a valid value (remove or update inline comment) - Update
migrate_db()inserver/db.pyto handle existing DBs — no schema ALTER needed since there's no CHECK constraint, but ensure seeds include savings items - Seed a 'Investments & Savings' line item (item_type='savings') in the Personal ledger default seeds in
server/db.pyinit_db() - Update
add_line_itemMCP tool to accept'savings'as validitem_type(currently validatesincome | expenseonly — update that validation) - Update any validation in
ui/server.pythat restricts item_type - Update ARCHITECTURE.md
line_itemssection to notesavingsas a valid type - Add tests in
tests/covering the new item_type
Why
Foundation for savings tracking. Issues #235, #248, and #237 all depend on this.
Acceptance criteria
add_line_itemacceptsitem_type='savings'without error- Default Personal ledger seeds include an 'Investments & Savings' savings line item
- All existing tests pass
Depends on
Nothing — this is the foundation.
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Assessment
This issue has not been assessed yet.