RexOps / RexOps/Rex

Rex::Test has_service_running kills test when service does not exist

Open
#808 0 comments 0 reactions 1 assignee View on GitHub

@ferki is already working on this.

Since Oct 19, 2015.

Dominant language
Perl
Stars
737
Forks
214
PR merge metrics
No merged PRs in 30d

Description

Running Rex::Test::Base->has_service_running against a service that does exist dies with an error instead of returning "not ok".

$t->has_service_running("php-fpm");

Returns:

[2015-10-19 09:39:48] ERROR - Error running t/httpd.t: Service php-fpm.service not found. at /usr/lib64/perl5/vendor_perl/5.20.2/Rex/Service/Base.pm line 40.

# Tests were run but no plan was declared and done_testing() was not seen.

instead of:

not ok 1 - Service php-fpm running.

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.