run_task should run before_task_start and after_task_finished hooks
Nobody has claimed this yet.
- Dominant language
- Perl
- Stars
- 737
- Forks
- 214
- PR merge metrics
- No merged PRs in 30d
Description
@krimdomu I think it would be a good idea to have run_task() execute the before_task_start and after_task_finished hooks. I talked to @krimdomu about this over IRC, and I think you were going to add it. I haven't seen any activity regarding it lately, so I'm posting this.
Do you think this is still a good idea?
We also talked about whether or not calling a task directly by function name should run these hooks. You recommended that by default it does not, but adding a feature flag to allow it.
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start by locating run_task() and the before_task_start and after_task_finished hook implementations. Determine how direct task calls currently behave and how a feature flag would fit the proposed default; done means the intended hook behavior is specified and covered for both run_task() and direct function-name calls.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- perl
- Domain
- devops
- Issue type
- Feature
- Difficulty
- 4/5
- Estimated time
- 3-5 days
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 35/100