Rex::SCM::Subversion and --trust-server-cert-failures

From @vikasnkumar on July 14, 2016 3:35

Hello @krimdomu

I am using Rex to manage some Ubuntu 16.06 Xenial servers where code from internal SVN repositories are being checked out and built.

Ubuntu Xenial has Subversion 1.9.3 and that supports the --trust-server-cert-failures option, which isn't supported in Rex::SCM::Subversion::checkout function.

That is ok. The checkout() function argument list has an option $checkout_opt for custom options from the user but this variable is not being used anywhere in creating the final run commandline.

Hence, I am having to use a hack like the following:

 if (is_dir($CODE_DIR)) {
        run "svn up --username $USER --password $PASSWD --non-interactive --trust-server-cert --trust-server-cert-failures cn-mismatch $CODE_DIR";
 } else {
        run "svn co --username $USER --password $PASSWD --non-interactive --trust-server-cert --trust-server-cert-failures cn-mismatch $REPO_URL $CODE_DIR";
  }

Please make an update that allows either $checkout_opt or --trust-server-cert-failures to work, preferably the former. That will also allow custom options like --depth=1 to work.

Thank you.

Copied from original issue: krimdomu/rex-scm#1

Start with Rex::SCM::Subversion::checkout and trace how its $checkout_opt argument is handled when creating the svn checkout and update commands. Verify the resulting run commands include custom options such as --trust-server-cert-failures or --depth=1 for both existing and new checkout directories.