RevenueCat / RevenueCat/react-native-purchases
`priceString` from `PurchasesStoreProduct` have not currency sign in response of RC test store (web)
Open
Nobody has claimed this yet.
bug
- Dominant language
- TypeScript
- Stars
- 1.2k
- Forks
- 117
- Avg merge
- 14h 40m
- Merged PRs (30d)
- 40
Description
- I have updated Purchases SDK to the latest version
- I have read the Contribution Guidelines
- I have searched the Community
- I have read docs.revenuecat.com
- I have searched for existing Github issues
As we can see from description for priceString prop:
priceString should return Formatted price of the item, including its currency sign, but for RC test store on web it returns currency code (not sign):
10 USD
but should be:
$10
- Environment
- Platform: web
- SDK version: 10.0.1
- React Native version: 0.81.5
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start with the PurchasesStoreProduct priceString definition in purchases-hybrid-common/typescript/src/offerings.ts around lines 97-101, then trace the web RC test store implementation that produces the value. Verify the web response formats the price with a currency sign rather than a currency code, and add or run coverage for the reported 10 USD case.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- react-native, typescript
- Domain
- payments, web-dev
- Issue type
- Bug
- Difficulty
- 3/5
- Estimated time
- 1-2 days
- Activity status
- Quiet
- Clarity
- Mostly clear
- Newbie friendliness
- 52/100