RevenueCat / RevenueCat/react-native-purchases
stripe.js downloaded after a single import of react-native-purchases
Open
Nobody has claimed this yet.
bug
- Dominant language
- TypeScript
- Stars
- 1.2k
- Forks
- 117
- Avg merge
- 14h 40m
- Merged PRs (30d)
- 40
Description
- [+] I have updated Purchases SDK to the latest version
- [+] I have read the Contribution Guidelines
- [+] I have searched the Community
- [+] I have read docs.revenuecat.com
- [+] I have searched for existing Github issues
Describe the bug
Importing the library automatically triggers stripe.js file downloads on web.
import "react-native-purchases"
It's pretty surprising and too much of behind the scenes, I'd consider this as a bug. No Stripe is enabled in my RC Dashboard.
- Environment
- Platform: Web
- SDK version:9.6.0
- OS version: Tahoe
- Xcode/Android Studio version: -
- React Native version: -
- SDK installation (CocoaPods + version or manual): -
- How widespread is the issue. Percentage of devices affected.
- Debug logs that reproduce the issue
- Steps to reproduce, with a description of expected vs. actual behavior
- Other information (e.g. stacktraces, related issues, suggestions how to fix, links for us to have context, eg. stackoverflow, etc.)
Additional context
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start from the web path exercised by a single import "react-native-purchases" and trace what initiates the stripe.js download. Reproduce with SDK 9.6.0 in a web environment, then verify that importing the library no longer downloads stripe.js when Stripe is not enabled.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- react-native, typescript
- Domain
- payments, web-dev
- Issue type
- Bug
- Difficulty
- 3/5
- Estimated time
- 1-2 days
- Activity status
- Quiet
- Clarity
- Mostly clear
- Newbie friendliness
- 52/100