RetroAchievements / RetroAchievements/RAIntegration
Revert button for server-side achievements reverts to state at login, not last committed state
Nobody has claimed this yet.
- Dominant language
- C++
- Stars
- 124
- Forks
- 34
- Avg merge
- 5d 18h
- Merged PRs (30d)
- 13
Description
IDC_RA_REVERTSELECTED in RA_Dlg_Achievement.cpp talks about "reverting from file" but the only thing that seems to write to file is IDC_RA_COMMIT_ACH when (g_nActiveAchievementSet == Local).
Using the "Revert selected" button when Unofficial set is selected leads to some unclear behaviour.
IMO it'd make sense if unofficial set actually reverted from server.
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start in RA_Dlg_Achievement.cpp with IDC_RA_REVERTSELECTED and compare its behavior with IDC_RA_COMMIT_ACH, especially the g_nActiveAchievementSet == Local condition. Trace how the Unofficial set obtains its state and determine whether reverting should use the server state rather than the state at login; done means the button consistently restores the intended last committed state.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- cpp
- Domain
- desktop
- Issue type
- Bug
- Difficulty
- 4/5
- Estimated time
- 3-5 days
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 35/100