RetroAchievements / RetroAchievements/AutoCR
[Feature] Allow hitcount/reset as an alternative to delta checks
Nobody has claimed this yet.
- Dominant language
- JavaScript
- Stars
- 3
- Forks
- 4
- PR merge metrics
- No merged PRs in 30d
Description
The use case is "Do X for Y seconds". Since we are asking the player to maintain a situation for a given period of time there is no relevant delta check to be made.
A logic storing hits when a condition is true and reseting them for the opposite condition is therefore a valid case for which delta checks are not needed.
This feature would have to check for a minimal conservative amount of frames to make sure that:
- logic predating delta checks is still in error (i.e. a hit target of 1 is not valid)
- people aren't using that to circumvent the need for delta check when they are not trying to follow the "Do X for Y seconds" pattern.
My wild guess is that we sould ask for at least 60 frames for it to be valid (it's one second for most systems).
Contributor guide
No contributing guide indexed for this repository
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start by locating the validation for hitcount/reset and delta checks, then find any existing tests covering frame thresholds or condition tracking. Define the smallest conservative frame minimum that preserves errors for legacy logic while allowing the “Do X for Y seconds” case; done means the new alternative is accepted only at that threshold and existing delta-check validation remains intact.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- javascript
- Domain
- tooling
- Issue type
- Feature
- Difficulty
- 4/5
- Estimated time
- 3-5 days
- Activity status
- Active
- Clarity
- Needs clarification
- Newbie friendliness
- 45/100