Respect / Respect/Validation

Rename Attributes to something else

Open
#1,800 5 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Discussion
Dominant language
PHP
Stars
6k
Forks
773
Avg merge
10h 6m
Merged PRs (30d)
17

Description

Considering the work I will be doing on #1799, I think Attributes might not be a good name for it anymore.

Considering options, I think ObjectStructure might be better, although I'm not very sure about it, if I'm really honest.

We could also keep Attributes as is, deprecate it, and then create ObjectStructure with the full support to @var doc blocks.

PS.: To be really honest, I was never a fan of Attributes() anyways, as it's validating the object and the attributes is just the means it does that right now.

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Read issue #1799 alongside this discussion and inspect how the current Attributes concept is used. The issue does not identify files or tests; done would require an agreed replacement name and a clear decision about retaining or deprecating Attributes and supporting @var doc blocks.

Written by the indexing model from the issue text.

Assessment

Tech stack
php
Domain
backend
Issue type
Refactor
Difficulty
5/5
Estimated time
Over a week
Activity status
Quiet
Clarity
Needs clarification
Newbie friendliness
25/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.