Rename Instance to IsInstanceOf
Nobody has claimed this yet.
- Dominant language
- PHP
- Stars
- 6k
- Forks
- 773
- Avg merge
- 10h 6m
- Merged PRs (30d)
- 17
Description
Not critical, but I think Instance is a bit cryptic, and doesn't really reflect the intent.
Side track here is that the best name would be InstanceOf, and the problem is that we can't rename classes like that, but we could still have a method with that name. If we change how the ValidatorFactor works to try loading a validator with a suffix Validator we could achieve that. I'm not saying we should rename all validators by adding a suffix to them, but we could also try loading a validator with that suffix.
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start by reviewing the existing Instance validator and the ValidatorFactor behavior described in the issue. Determine whether loading validators with a Validator suffix can support an InstanceOf method without renaming classes; done means the naming change and compatibility behavior are clearly defined and validated.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- php
- Domain
- backend
- Issue type
- Refactor
- Difficulty
- 5/5
- Estimated time
- Over a week
- Activity status
- Stale
- Clarity
- Needs clarification
- Newbie friendliness
- 25/100