Redocly / Redocly/redoc

Wrong height when there is more elements on page

Open
#2,453 4 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Type: Enhancement
Dominant language
TypeScript
Stars
25.9k
Forks
2.4k
Avg merge
13h 10m
Merged PRs (30d)
4

Description

Describe the problem to be solved
If Redoc element is only element in page, than height is correctly calculated to take 100%.
But if there is more elements on page (footer/header) than Redoc still takes 100% of page height and last elements in menu are hidden

Describe the solution you'd like
Since already using flex, position elements with flex too, so that it's possible to have more elements on page.

Additional context

Please note last visible element in menu

Without footer/header:

Screenshot 2023-11-20 at 11 32 06

With footer/header:

Screenshot 2023-11-20 at 11 34 31

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

No source file or test is named in the issue. First reproduce the layout with a Redoc element alongside a header or footer, then trace the existing flex-based height calculation; done means surrounding page elements fit without Redoc forcing the page to 100% height and the final menu entries remain visible.

Written by the indexing model from the issue text.

Assessment

Tech stack
css, react, typescript
Domain
frontend
Issue type
Bug
Difficulty
3/5
Estimated time
1-2 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
38/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.