RedisGears / RedisGears/LibMR

Fix thpool.c volatile usage

Open
#52 0 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Dominant language
C
Stars
5
Forks
6
Avg merge
3h 52m
Merged PRs (30d)
1

Description

It seems like thpool.c makes a wrong assumption that volatile can be use for thread synchronization. We should replace the use of volatile with atomic variables.

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start by reviewing thpool.c and locating each use of volatile, then trace how those variables are used for thread synchronization. Replace the synchronization assumptions with atomic variables as described in the issue, and verify that the thread-pool behavior remains correct under concurrent use.

Written by the indexing model from the issue text.

Assessment

Tech stack
c
Domain
backend
Issue type
Bug
Difficulty
4/5
Estimated time
3-5 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
35/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.