RedHatTraining / RedHatTraining/DO288-apps
kill.sh curl request get var doesn't match req.query.op values.
Nobody has claimed this yet.
- Dominant language
- Mustache
- Stars
- 139
- Forks
- 13.7k
- Avg merge
- 3d 19h
- Merged PRs (30d)
- 16
Description
kill.sh contents:
#!/bin/bash
source /usr/local/etc/ocp4.config
APP_URL=probes-${RHT_OCP4_DEV_USER}-probes.${RHT_OCP4_WILDCARD_DOMAN}
curl http://$APP_URL/flip?op=kill
But apps.js contents:
// This route handles switching the state of the app
route.route('/flip').get(function (req, res) {
var flag = req.query.op;
if (flag === 'kill-health') {
console.log('Received kill request for health probe.');
healthy = false;
res.send('Switched app state to unhealthy...\n');
} else if (flag === "awaken-health") {
console.log('Received awaken request for health probe.');
healthy = true;
res.send('Switched app state to healthy...\n');
} else if (flag === 'kill-ready') {
console.log('Received kill request for readiness probe.');
ready = false;
res.send('Switched app state to not ready...\n');
} else if (flag === 'awaken-ready') {
console.log('Received awaken request for readiness probe.');
ready = true;
res.send('Switched app state to ready...\n');
} else {
res.send('Error! unknown flag...\n');
}
});
there is no value for op=kill
Contributor guide
No contributing guide indexed for this repository
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Compare the request in kill.sh with the supported req.query.op values in apps.js, starting at the /flip route. Align the curl request with the intended supported kill operation, then verify that the endpoint no longer reports an unknown flag.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- bash, javascript
- Domain
- api, backend
- Issue type
- Bug
- Difficulty
- 2/5
- Estimated time
- 1-3 hours
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 35/100