RedHatQE / RedHatQE/timeout-sampler

When using the `retry` decorator, mypy complains and gives an error.

Open
#112 0 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Dominant language
Python
Stars
0
Forks
4
Avg merge
8h 53m
Merged PRs (30d)
8

Description

The error seen when decorating with retry:

libs/net/vmspec.py:41: error: Untyped decorator makes function "_lookup_iface_status" untyped  [misc]

It seems there is a need to preserve the signature of the wrapped function as described here.

Contributor guide

No contributing guide indexed for this repository

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start with the retry decorator and its use at libs/net/vmspec.py:41, then compare the implementation with mypy's linked guidance on declaring decorators. The change is done when mypy no longer reports the untyped-decorator error for _lookup_iface_status while preserving the wrapped function's signature.

Written by the indexing model from the issue text.

Assessment

Tech stack
python
Domain
tooling
Issue type
Bug
Difficulty
3/5
Estimated time
1-2 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
48/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.