RealDevSquad / RealDevSquad/website-backend

Fixing api route `users/userId/{userId}`

Open
#966 2 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

backend
Dominant language
JavaScript
Stars
74
Forks
276
Avg merge
1d 26m
Merged PRs (30d)
14

Description

The api route users/userId/{userId} needs to be added in to users/ , as this doesn't follow API designing rules.

So the query parameter will be added to /users/ which is currently authenticated, need to make it public.

https://github.com/Real-Dev-Squad/website-backend/blob/0afb67b4c97a51f7c964808b89b0832f485b22fc/routes/users.js#LL12

  • need to check where all this api is used
  • list all the places where this api is used
  • Real-Dev-Squad/website-dashboard#336
  • Real-Dev-Squad/website-api-contracts#115
  • #983
  • Have a deployment plan to release the change.

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start with routes/users.js at the linked route definition, then check the places where this API is used as noted in the checklist. The route change is done when the userId query is supported through /users/, authentication behavior is addressed, the dashboard and API-contract issues are resolved, and a deployment plan exists.

Written by the indexing model from the issue text.

Assessment

Tech stack
javascript, nodejs
Domain
api, backend
Issue type
Refactor
Difficulty
4/5
Estimated time
3-5 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
25/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.