RealDevSquad / RealDevSquad/website-backend
Remove middlewares when removing the feature flag from Extention Requests
Open
Nobody has claimed this yet.
- Dominant language
- JavaScript
- Stars
- 74
- Forks
- 276
- Avg merge
- 1d 26m
- Merged PRs (30d)
- 14
Description
Issue Description
Remove the skipAuthorizeRolesUnderFF & authorizeRoles middleware when removing the feature flag from edit Extension Requests flow that is added on the below mentioned PR
Expected Behavior
Current Behavior
Screenshots
Reproducibility
- This issue is reproducible
- This issue is not reproducible
Steps to Reproduce
Severity/Priority
- Critical
- High
- Medium
- Low
Additional Information
Checklist
- I have read and followed the project's code of conduct.
- I have searched for similar issues before creating this one.
- I have provided all the necessary information to understand and reproduce the issue.
- I am willing to contribute to the resolution of this issue.
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Review PR #2215 and search the backend for the edit Extension Requests flow, skipAuthorizeRolesUnderFF, and authorizeRoles. Remove those middleware references where the feature flag is being removed, then run the relevant backend checks and confirm the edit flow no longer depends on them.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- javascript, node.js
- Domain
- api, authorization, backend
- Issue type
- Refactor
- Difficulty
- 2/5
- Estimated time
- 1-3 hours
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 48/100