RealDevSquad / RealDevSquad/website-backend

Remove dev feature flag from GET /users API

Open
#2,142 0 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Dominant language
JavaScript
Stars
74
Forks
276
Avg merge
1d 26m
Merged PRs (30d)
14

Description

Issue Description

This API has been live on prod for a long time but the feature flag has not been removed.
Remove the dev FF from backend and all other repos where its being used.

Reason for adding dev FF

  1. To get user by discord id through a query param for /user discord command
  2. Change query param with name query to q

Usages in other repos

  1. discord-slash-commands - Partial use 🟨
  2. members-site - None of the usages are using dev FF 🟥
  3. mobile-app - None of the usages are using dev FF 🟥
  4. website-dashboard - None of the usages are using dev FF 🟥
  5. website-status - None of the usages are using dev FF 🟥

This is a subtask of #2075

Expected Behavior
Current Behavior
Screenshots

NA

Reproducibility
  • This issue is reproducible
  • This issue is not reproducible
Steps to Reproduce

NA

Severity/Priority
  • Critical
  • High
  • Medium
  • Low
Additional Information
Checklist
  • I have read and followed the project's code of conduct.
  • I have searched for similar issues before creating this one.
  • I have provided all the necessary information to understand and reproduce the issue.
  • I am willing to contribute to the resolution of this issue.

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start by searching the website-backend repository for the dev feature flag and the GET /users endpoint, then check its usages in discord-slash-commands, members-site, mobile-app, website-dashboard, and website-status. Confirm which usages still depend on the flag and the query parameters before removing it from the backend and affected repositories. Done means the flag is removed everywhere it is used without losing the Discord ID lookup or the q query parameter behavior.

Written by the indexing model from the issue text.

Assessment

Tech stack
javascript, node.js
Domain
api, backend
Issue type
Refactor
Difficulty
4/5
Estimated time
3-5 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
38/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.