ReadYouApp / ReadYouApp/ReadYou
AlertDialog disappears on orientation change
Nobody has claimed this yet.
- Dominant language
- Kotlin
- Stars
- 7.5k
- Forks
- 330
- PR merge metrics
- No merged PRs in 30d
Description
1. Environment
- Device: [Xiaomi Redmi Note 8 Pro]
- OS: [Android 14]
- APP: [0.9.12]
Note: not fixed in 0.10.1
2. Describe the bug
Problem: when I perform this sequence of events the AlertDialog disappears:
- Touch the settings icon at the top left
- Touch Accounts
- Open an account
- Touch one of the following:
- Display, then Name
- Syncing, then Sync
- Syncing, then Keep achieved articles
- Syncing, then Export as OPML
- Rotate the device twice
or:
- Touch the settings icon at the top left
- Touch Color & style
- Touch Basic fonts
- Rotate the device twice
or:
- Touch the settings icon at the top left
- Touch Color & style
- Touch Feeds Page
- Touch one of the following:
- TopBar, then Tonal elevation
- Group List, then Tonal elevation
- Filter Bar, then Style
- Filter Bar, then Horizontal padding
- Filter Bar, then Tonal elevation
- Rotate the device twice
or:
- Touch the settings icon at the top left
- Touch Color & style
- Touch Flow Page
- Touch one of the following:
- TopBar, then Tonal elevation
- Article List, then Grey out articles
- Article List, then Tonal elevation
- Filter Bar, then Style
- Filter Bar, then Horizontal padding
- Filter Bar, then Tonal elevation
- Rotate the device twice
or:
- Touch the settings icon at the top left
- Touch Color & style
- Touch Reading Page
- Touch one of the following:
- Reading fonts
- Tonal elevation
- Title, then Alignment
- Text, then Font Size
- Text, then Letter spacing
- Text, then Horizontal padding
- Text, then Alignment
- Images, then Rounded corners
- Images, then Horizontal padding
- Rotate the device twice
Possible solution:
use rememberSaveable instead of remember in the following occurrencies:
- app/src/main/java/me/ash/reader/ui/page/settings/accounts/AccountDetailsPage.kt:77, 83, 84, 85
- app/src/main/java/me/ash/reader/ui/page/settings/color/ColorAndStylePage.kt:59
- app/src/main/java/me/ash/reader/ui/page/settings/color/feeds/FeedsPageStylePage.kt:40, 41, 42, 43, 44
- app/src/main/java/me/ash/reader/ui/page/settings/color/flow/FlowPageStylePage.kt:46-51
- app/src/main/java/me/ash/reader/ui/page/settings/color/reading/ReadingStylePage.kt:51, 52
- app/src/main/java/me/ash/reader/ui/page/settings/color/reading/ReadingTitlePage.kt:39
- app/src/main/java/me/ash/reader/ui/page/settings/color/reading/ReadingTextPage.kt:39-42
- app/src/main/java/me/ash/reader/ui/page/settings/color/reading/ReadingImagePage.kt:32, 33
Screenshots:
Contributor guide
No contributing guide indexed for this repository
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start by reproducing the orientation-change sequence in the listed settings files, beginning with AccountDetailsPage.kt and the ColorAndStylePage.kt subpages. Compare the listed remember occurrences with the dialog state behavior, then verify across the affected account, font, feed, flow, reading, and image settings that open dialogs remain visible after two rotations.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- android, kotlin
- Domain
- design, mobile
- Issue type
- Bug
- Difficulty
- 3/5
- Estimated time
- 1-2 days
- Activity status
- Stale
- Clarity
- Clearly specified
- Newbie friendliness
- 48/100