ReadYouApp / ReadYouApp/ReadYou

Support forma unicode chars con url

Open
#1,129 0 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

bug untriaged
Dominant language
Kotlin
Stars
7.5k
Forks
330
PR merge metrics
No merged PRs in 30d

Description

Checklist
  • I've already searched in existing issues and haven't found a similar problem reported.
  • I'm using the latest version of the app
  • This error caused the app to crash
  • This error is reproducible
Which category best fits this error?

Feed Management

App version

0.14.4

Reproduction steps
1. Create a local account
2. Add the next url and clicking search: 'マリウス.com'

Log:
Version: 0.14.4
Device: samsung SM-G781B
System: Android 13 (API 33)

Stack trace: 

.lang.IllegalArgumentException: Unexpected char 0x30de at 0 in Referer value: マリウス.com
	at okhttp3.internal._HeadersCommonKt.headersCheckValue(-HeadersCommon.kt:123)
	at okhttp3.Headers$Builder.add(Headers.kt:15)
	at me.ash.reader.ui.component.base.RYAsyncImageKt.RYAsyncImage(RYAsyncImage.kt:444)
	at me.ash.reader.ui.component.FeedIconKt.FeedIcon-hGBTI10(FeedIcon.kt:316)
	at me.ash.reader.ui.page.home.feeds.subscribe.SubscribeDialogKt.SubscribeDialog$lambda$19(SubscribeDialog.kt:51)
	at me.ash.reader.ui.page.home.feeds.subscribe.SubscribeDialogKt.$r8$lambda$fraKeqMjbSXJ3ebaMgjNu3sq8Us(SubscribeDialog.kt:1)
	at me.ash.reader.ui.page.home.feeds.subscribe.SubscribeDialogKt$$ExternalSyntheticLambda12.invoke(R8$$SyntheticClass:11)
	at androidx.compose.runtime.internal.ComposableLambdaImpl.invoke(ComposableLambda.kt:11)
	at androidx.compose.runtime.internal.ComposableLambdaImpl$invoke$1.invoke(ComposableLambda.kt:13)
	at androidx.compose.runtime.ComposerImpl.recomposeToGroupEnd(Composer.kt:551)
	at androidx.compose.runtime.ComposerImpl.skipCurrentGroup(Composer.kt:161)
	at androidx.compose.runtime.ComposerImpl.doCompose-aFTiNEg(Composer.kt:124)
	at androidx.compose.runtime.CompositionImpl.recompose(Composition.kt:74)
	at androidx.compose.runtime.Recomposer.performRecompose(Recomposer.kt:68)
	at androidx.compose.runtime.Recomposer$runRecomposeAndApplyChanges$2$$ExternalSyntheticLambda0.invoke(R8$$SyntheticClass:588)
	at androidx.compose.ui.platform.AndroidUiFrameClock$withFrameNanos$2$callback$1.doFrame(AndroidUiFrameClock.android.kt:7)
	at androidx.compose.ui.platform.AndroidUiDispatcher$dispatchCallback$1.doFrame(AndroidUiDispatcher.android.kt:48)
	at android.view.Choreographer$CallbackRecord.run(Choreographer.java:1299)
	at android.view.Choreographer$CallbackRecord.run(Choreographer.java:1309)
	at android.view.Choreographer.doCallbacks(Choreographer.java:923)
	at android.view.Choreographer.doFrame(Choreographer.java:847)
	at android.view.Choreographer$FrameDisplayEventReceiver.run(Choreographer.java:1283)
	at android.os.Handler.handleCallback(Handler.java:942)
	at android.os.Handler.dispatchMessage(Handler.java:99)
	at android.os.Looper.loopOnce(Looper.java:226)
	at android.os.Looper.loop(Looper.java:313)
	at android.app.ActivityThread.main(ActivityThread.java:8762)
	at java.lang.reflect.Method.invoke(Native Method)
	at com.android.internal.os.RuntimeInit$MethodAndArgsCaller.run(RuntimeInit.java:604)
	at com.android.internal.os.ZygoteInit.main(ZygoteInit.java:1067)
	Suppressed: kotlinx.coroutines.internal.DiagnosticCoroutineContextException: [androidx.compose.runtime.PausableMonotonicFrameClock@543a480, androidx.compose.ui.platform.MotionDurationScaleImpl@4ec3ab9, StandaloneCoroutine{Cancelling}@68f8efe, AndroidUiDispatcher@f25765f]

Contributor guide

No contributing guide indexed for this repository

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start with RYAsyncImage.kt at the failing line, then trace how FeedIcon.kt and SubscribeDialog.kt pass the entered URL during the search flow. Reproduce the crash with the Unicode URL マリウス.com; done means the feed search and icon loading no longer crash for that input.

Written by the indexing model from the issue text.

Assessment

Tech stack
android, kotlin
Domain
mobile
Issue type
Bug
Difficulty
3/5
Estimated time
1-2 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
48/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.