We forgot to deprecate the resultSelector for combineLatest
Open
@benlesh is already working on this.
Since Feb 8, 2023.
- Dominant language
- TypeScript
- Stars
- 31.7k
- Forks
- 3k
- PR merge metrics
- No merged PRs in 30d
Description
As mentioned here: https://github.com/ReactiveX/rxjs/pull/7168
I think the code in that section was sufficiently complicated as to obscure that we forgot to deprecate that signature.
That gives us two options:
- Deprecated it now and wait until v9. (Maybe a year?)
- Just remove it as part of the set of breaking changes in v8.
I'm fine with either, but I'm a little sad if we have to leave it, I was hoping to clean everything up this version.
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Assessment
This issue has not been assessed yet.