ReactiveX / ReactiveX/rxjs

Incorrect Intellisense description for `forkJoin`

Open
#7,100 6 comments 6 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Dominant language
TypeScript
Stars
31.7k
Forks
3k
PR merge metrics
No merged PRs in 30d

Description

Describe the bug

In the example code below, the hover definition for forkJoin displays a description about the any type, even when the any type is not used.

You have passed any here, we can't figure out if it is an array or an object, so you're getting unknown. Use better types.

In the example below, TypeScript inferred a tuple type [number, number].

image

Expected behavior

Hover definition for forkJoin displays the main/standard documentation definition for forkJoin.

Reproduction code
import { forkJoin, of } from 'rxjs'

forkJoin([of(1), of(2)])
Reproduction URL

No response

Version

7.5.7

Environment

Visual Studio Code (latest version - v1.7.2)
TypeScript bundled with VS Code (v4.8.4)

Additional context

No response

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start by reproducing the hover output for the provided TypeScript example in VS Code, focusing on the forkJoin entry point and its inferred tuple type. Trace which forkJoin documentation is selected for that overload, then verify that the hover shows the standard forkJoin definition without the any-type warning.

Written by the indexing model from the issue text.

Assessment

Tech stack
typescript
Domain
developer-experience
Issue type
Bug
Difficulty
3/5
Estimated time
1-2 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
35/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.