Notifier subscription order inconsistencies
Nobody has claimed this yet.
- Dominant language
- TypeScript
- Stars
- 31.7k
- Forks
- 3k
- PR merge metrics
- No merged PRs in 30d
Description
The order in which the following operators make their subscriptions to the source and notifier observables seems inconsistent:
| Operator | Order in v6 | Order in v7 | Breaking |
|---|---|---|---|
buffer |
closings, source | source, closings | Y |
bufferToggle |
openings, source | openings, source | N |
sample |
source, notifier | source, notifier | N |
skipUntil |
notifier, source | notifier, source | N |
takeUntil |
notifier, source | notifier, source | N |
window |
source, boundaries | source, boundaries | N |
windowToggle |
openings, source | openings, source | N |
IDK that anything needs to be done, ATM, but I think the change made to buffer in v7 should either be included in the breaking changes - if it's not already there - or the subscription order for that operator should be reversed.
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
No files or tests are named. Start by comparing subscription order for the listed operators, especially buffer, across the v6 and v7 implementations. Done means deciding whether buffer's changed order is an intended breaking change to document or should be reversed, with the decision reflected in the relevant project changes.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- typescript
- Domain
- api
- Issue type
- Bug
- Difficulty
- 4/5
- Estimated time
- 3-5 days
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 35/100