ReactiveX / ReactiveX/rxjs

bug(partition): Subscribes to the source twice, when it should probably multicast

Open
#5,731 3 comments 1 reaction 0 assignees View on GitHub

Nobody has claimed this yet.

bug
Dominant language
TypeScript
Stars
31.7k
Forks
3k
PR merge metrics
No merged PRs in 30d

Description

Currently partition will subscribe to whatever observable you get twice. Given that it is supposed to "partition", which sounds like splitting one thing into several parts, I'd think it should multicast the source.

ALSO: The partition operator just needs to be removed in favor of groupBy, as it doesn't make any sense as an operator with pipe.

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start by locating the partition and groupBy entry points in the TypeScript source, then inspect how partition is used with pipe. Done means the project has a decided resolution—either the subscription behavior is corrected or the operator is removed in favor of groupBy—and tests document that outcome.

Written by the indexing model from the issue text.

Assessment

Tech stack
javascript, typescript
Domain
tooling
Issue type
Bug
Difficulty
5/5
Estimated time
Over a week
Activity status
Stale
Clarity
Needs clarification
Newbie friendliness
25/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.