Add documentation about why people should almost never inherit from our exports.
Open
@benlesh is already working on this.
Since Aug 13, 2020.
- Dominant language
- TypeScript
- Stars
- 31.7k
- Forks
- 3k
- PR merge metrics
- No merged PRs in 30d
Description
There are a lot of issues with doing this, and I think it needs to be in the official documentation that people should avoid doing it, and if they're doing it they're "voiding the warranty", so to speak.
High level:
- How they can end up relying on implementation details.
- How custom observables and subjects can break operators.
- etc.
Tangentially related #5431
I'll probably add this to the new guide in #5592
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Assessment
This issue has not been assessed yet.