ReactiveX / ReactiveX/rxjs

WebSocketSubject may have different input and output types.

Open
#5,381 2 comments 2 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

bug help wanted
Dominant language
TypeScript
Stars
31.7k
Forks
3k
PR merge metrics
No merged PRs in 30d

Description

Just what the title says... The AnonymousSubject (aka "frankensubject") probably also needs some typings love.

Basically, a nicer interface would be:

class WebSocketSubject<In, Out> extends Observable<Out> implements Observer<In> {
  // ...stuff
}

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start with the WebSocketSubject and AnonymousSubject entry points and inspect their current TypeScript typings. Confirm that WebSocketSubject can express separate input and output types, then verify that the corresponding public typings and existing type checks cover the intended interfaces.

Written by the indexing model from the issue text.

Assessment

Tech stack
typescript
Domain
api
Issue type
Feature
Difficulty
3/5
Estimated time
1-2 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
38/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.