ReactiveX / ReactiveX/rxjs

Virtual/TestScheduler allows negative frame scheduling

Open
#4,042 1 comment 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Dominant language
TypeScript
Stars
31.7k
Forks
3k
PR merge metrics
No merged PRs in 30d

Description

Currently, you can schedule using any VirtualScheduler with a negative delay. This makes little to no sense. We should probably throw an error here.

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start by locating VirtualScheduler and TestScheduler in the TypeScript source and inspect how delays are scheduled. Confirm the current behavior with a negative delay, then ensure negative frame scheduling is rejected and verify the relevant scheduler behavior with the existing tests.

Written by the indexing model from the issue text.

Assessment

Tech stack
typescript
Domain
testing
Issue type
Bug
Difficulty
2/5
Estimated time
1-3 hours
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
38/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.