ReactiveX / ReactiveX/RxPY

Example noteboks are out of date

Open
#265 2 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

PR welcome
Dominant language
Python
Stars
5k
Forks
365
Avg merge
3d 14h
Merged PRs (30d)
4

Description

There are few places where examples in the notebooks are using wrong keyword parameters,
eg Part VI buffer

--------------------------------------------------
TypeError        Traceback (most recent call last)
<ipython-input-6-eb223277a679> in <module>()
      4 opens  = marble_stream('oo---------------------------------------------------|')
      5 closes = marble_stream('-------------------------c|')
----> 6 d = subs(xs.buffer(buffer_openings=opens, buffer_closing_mapper=lambda: closes))

TypeError: buffer() got an unexpected keyword argument 'buffer_closing_mapper'

group_by

--------------------------------------------------
TypeError        Traceback (most recent call last)
<ipython-input-8-cd035db1f337> in <module>()
     16 src = O.from_(codes).group_by(
     17     key_mapper     = lambda x: x[keyCode], # id of (potentially new) streams
---> 18     element_mapper = lambda x: x[keyCode]  # membership to which stream
     19 )
     20 # we have now 6 streams

TypeError: group_by() got an unexpected keyword argument 'key_mapper'

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Find the Part VI buffer example and the group_by example in the notebooks, then read the current RxPY signatures for the parameters shown in each traceback. Run the affected notebook examples and update the outdated keyword arguments until both examples execute without the reported TypeErrors.

Written by the indexing model from the issue text.

Assessment

Tech stack
jupyter-notebook, python
Domain
documentation
Issue type
Documentation
Difficulty
3/5
Estimated time
1-2 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
45/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.